2 POST forms, not posting correctly

I've been looking over these post forms looking for reasons why it's not posting the hidden $event_id. This value is being populated in the form when looking at the page source, but isn't getting passed to the event_signup.html page. Can anyone take a look and let me know if they see anything wrong? The html looks to be nested correctly....I thought maybe because there are 2 forms on the page and it's calling the validation function with "this"?

FYI, we use a heredoc on this page, hence no quotes and the like.

<table cellpadding=3 cellspacing=3>
<tbody>
<tr>
<td valign="top">
<form id="sign" name="sign" METHOD="post" action="event_signup.html" onSubmit="return validate_form(this);">
<input type="hidden" value="$event_id" />
<table cellpadding=3 cellspacing=3>
<tbody>
<tr>
<td colspan="2">Please enter your member ID<br />to make your reservation.<br /></td>
</tr>
<tr>
<td><legend for="customer_membership_id">Membership id:</legend></td>
<td><input name="customer_membership_id" id="customer_membership_id" type="text" size=14 value="" /></td>
</tr>
<tr>
<td colspan="2" align="right" id="form_id" name="form_id"></td>
</tr>
<tr>
<td colspan="2" align="right">
<table>
<tr>
<td><input type="submit" value="Make Reservation"></td>
<td width=20> </td>
<td><input type="reset" value="Clear"/></td>
</tr>
</table></td>
</tr>
</tbody>
</table></form></td>
<td width=60> </td>
<td valign="top">
<form id="signup" name="signup" METHOD="post" action="event_signup.html" onsubmit="return call_agenda(this);">
<table cellpadding=3 cellspacing=3>
<tbody>
<tr>
<td colspan="2" align="left">Send my member ID to<br />my registered e-mail address.<br /></td>
</tr>
<tr>
<td><legend for="customer_email">E-mail Adress:</legend></td>
<td><input name="customer_email" id="customer_email" type="text" size=20 value="" /></td>
</tr>
<tr>
<td colspan="2" align="right" id="form_content" name="form_content"></td>
</tr>
<tr>
<td colspan="2" align="right">
<table>
<tr>
<td><input type="submit" value="Send"></td>
<td width=20> </td>
<td><input type="reset" value="Clear"/></td>
</tr>
</table></td>
</tr>
</tbody>
</table></td>
</tbody>
</table>
<br/>
Not a member? <a href="/new_members.html">Register and signup here.</a>
</div>

================================
Angela Gann
CrimsonDryad Web Design Services
Web Design, Custom Software Development
http://www.crimsondryad.com

Your form isn't making any sense to me at all. You appear to be using JavaScript to do form validation and submission (a double-plus ungood, by the way) but you haven't shown your JavaScript. Are you processing the form as PHP?

Hi scjessey. :)

I actually didn't write this script, my (now-fired) other programmer did, so I can't tell you all the logic because I think he writes jacked up code. :P Unfortunately, we're too far through this project to just rip out his craziness. But yes, this is a PHP-generated page. That section is using a heredoc, which is how we have $event_id showing up without something like <?= $event_id ?>.

He used separate Javascript functions to do validation and submission (and yes, I would agree, a double ungood). He's absolutely obsessed with ajaxy stuff. Ajax is good, but it's not the end all to everything.

Here are the functions, and yes they are calling more Javascript code. Including it all would be involved and confusing. If you tell me he's nuts and I should just rewrite that piece, I'll take your advice seriously...though I'd rather just fix it and move on.

<script language="Javascript" type="text/javascript">

var globVar = 1;
function doNext()
{
var sleeping = true;
var now = new Date();
}
function validate_form( form )
{
var ajax = new GLM.AJAX();
var main_container = document.getElementById("form_id");
main_container.innerHTML = '';
globVar = 1;
if (!validateNotEmpty( form.customer_membership_id.value ))
{
globVar = 0;
}
ajax.callPage('forms_api.html?mbers='+form.customer_membership_id.value, pageCallback);
alert("Checking id please wait...");
if (globVar>0) return true;
if (globVar<1)
{
main_container.innerHTML = '<font color=#ff0000>Invalid membership id.</font>';
form.customer_membership_id.focus();
return false;
}
}
function pageCallback(response)
{
globVar = 1;
if (response.length > 0) var str = eval(response);
return false;
}
function call_agenda( form )
{
var ajax = new GLM.AJAX();
var main_container = document.getElementById("form_content");
main_container.innerHTML = '';
if (!validateEmail( form.customer_email.value ))
{
main_container.innerHTML = '<font color=#ff0000>Invalid email address.</font>';
form.customer_email.focus();
return false;
}
else
{
ajax.callPage("forms_api.html?reminder="+form.customer_email.value, pageCallback2);
}
return false;
}
function pageCallback2(response)
{
var main_container = document.getElementById("form_content");
main_container.innerHTML = '';
if(response == '')
{
main_container.innerHTML = 'Email sent.';
}
else
{
main_container.innerHTML = response;
}
return false;
}
function validateNotEmpty( strValue )
{
var strTemp = strValue;
strTemp = trimAll(strTemp);
if(strTemp.length > 0)
{
return true;
}
return false;
}
function trimAll( strValue )
{
var objRegExp = /^(s*)$/;
if(objRegExp.test(strValue))
{
strValue = strValue.replace(objRegExp, '');
if( strValue.length == 0) return strValue;
}
objRegExp = /^(s*)([Ww]*)(bs*$)/;
if(objRegExp.test(strValue)) strValue = strValue.replace(objRegExp, '$2');
return strValue;
}
function validateEmail( strValue )
{
var objRegExp = /(^[a-z]([a-z_.]*)@([a-z_.]*)([.][a-z]{3})$)|(^[a-z]([a-z_.]*)@([a-z_.]*)(.[a-z]{3})(.[a-z]{2})*$)/i;
return objRegExp.test(strValue);
}
</script>

================================
Angela Gann
CrimsonDryad Web Design Services
Web Design, Custom Software Development
http://www.crimsondryad.com

My JavaScript isn't very good, but it looks as if you are submitting either form to itself for validation. I can't see your PHP, but my guess is that $event_id is being passed but you aren't collecting it properly. Remember that since you are using POST as the method of the forms, the variable is only going to be accessible as $_POST['event_id'] because of the fact the register_globals is disabled.

I don't see a closing form tag for the second form. Am I just missing it?

It's getting to the source of the page. The $event_id is ok because that var is actually being set with a PHP function call.

I think that's the reason he used the Javascript for validation and submission, because he was keeping the person on the same page while validating their member id. If he did an HTML submit, the PHP function would run again.

My javascript is poor too. Just haven't had time to learn it, though I may have to now.

================================
Angela Gann
CrimsonDryad Web Design Services
Web Design, Custom Software Development
http://www.crimsondryad.com

In reply to:

---

<input type="hidden" value="$event_id" />

---

Don't you need to give it a name or id?

I don't see how you'd be collecting $event_id, even if its value is printing out in the source.

In reply to:

---

Don't you need to give it a name or id?

---

He's right. It will need a name, or it simply won't be passed in the POST data.

Good catch... though I fixed that and it's still not passing. *sigh*

================================
Angela Gann
CrimsonDryad Web Design Services
Web Design, Custom Software Development
http://www.crimsondryad.com

Thanks guys, I really appreciate that several of you are helping on this. I had an idea that it's probably something fairly easy to fix, but debugging is hell.

The post form is passing the customer_membership_id, which looking at what's there, I'm not sure how since I don't see where it's populating that. But it's not passing the event_id.

I hate Javascript. I think that's where the problem is right now. An alert box pops up that the user has to click "OK" on that says "Validating member id" I think he's got it set up that way right now because he was debugging.



================================
Angela Gann
CrimsonDryad Web Design Services
Web Design, Custom Software Development
http://www.crimsondryad.com

When you created a name for that value, did you then work that name into the receiving page that processes it?

Otherwise, if the name was left out of page 1, there probably wasn't anything in page 2 to handle it.

Nah, I'm doing print_r($_POST) right now because I'm debugging. I also cleared the cache and resubmitted the form from scratch, no joy.

================================
Angela Gann
CrimsonDryad Web Design Services
Web Design, Custom Software Development
http://www.crimsondryad.com

Ok, I get points for the developmentally slow approach. I had opened the file for reading and not writing and I assumed when I clicked the "save" button that it was saving, when in fact it was not.

So once I saved it with the event_id name, it worked.

Thanks again guys!

================================
Angela Gann
CrimsonDryad Web Design Services
Web Design, Custom Software Development
http://www.crimsondryad.com

Good... because I was out of ideas.

Eh, but I didn't know that. So I can still worship your greatness in divine ignorance. hehehe

================================
Angela Gann
CrimsonDryad Web Design Services
Web Design, Custom Software Development
http://www.crimsondryad.com